Bug 70056

Summary: [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
Product: WebKit Reporter: Robert Hogan <robert>
Component: Tools / TestsAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ddkilzer, eric, robert
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Robert Hogan
Reported 2011-10-13 14:37:53 PDT
This allows git diffs to match the ordering of svn diffs, where LayoutTests are left to the end of the patch. It makes patches easier to review because the code changes are always at the after the blurb in the Changelog.
Attachments
Patch (2.39 KB, patch)
2011-10-13 14:43 PDT, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Patch (6.78 KB, patch)
2011-10-15 09:19 PDT, Robert Hogan 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2011-10-13 14:43:57 PDT
Created attachment 110908 [details] Patch
Adam Barth
Comment 2 2011-10-13 14:53:38 PDT
Comment on attachment 110908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110908&action=review > Tools/Scripts/webkitpy/common/checkout/scm/git.py:255 > + order_file = tempfile.NamedTemporaryFile() Should this just be a static file in the config directory? (You can look at the watchlist config file to see how to find the path to config files.) That seems better that creating and destroying it every time. Also, please include a test.
Robert Hogan
Comment 3 2011-10-15 09:19:20 PDT
Created attachment 111137 [details] Patch
Adam Barth
Comment 4 2011-10-15 11:13:07 PDT
Comment on attachment 111137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111137&action=review > Tools/ChangeLog:14 > + * Scripts/webkitpy/common/config/orderfile: Added. I might have called the file something slightly different, like patchorder, but orderfile is ok to. Thanks!
Robert Hogan
Comment 5 2011-10-15 12:14:12 PDT
Committed r97561: <http://trac.webkit.org/changeset/97561>
Note You need to log in before you can comment on or make changes to this bug.