Summary: | [Qt][WK2] WebViews are emitting loadFailed for "private" error codes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jesus Sanchez-Palencia <jesus> | ||||
Component: | WebKit Qt | Assignee: | Jesus Sanchez-Palencia <jesus> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kenneth, kling, menard | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jesus Sanchez-Palencia
2011-10-13 12:46:43 PDT
Created attachment 110890 [details]
Patch
Comment on attachment 110890 [details]
Patch
Possible to test this?
(In reply to comment #2) > (From update of attachment 110890 [details]) > Possible to test this? I don't think so =/. Maybe only if the test rely on private stuff... but I'm not sure it makes sense. The good thing about this patch is that if anyone ever thinks these errors should emit loadFailed it's easy to remove those lines. Plus, other ports do the same on their FrameLoaderClient implementation in WebKit1 and we ourselves used to do the same in FrameLoaderClientQt::shouldFallBack. So I guess we are safe here... Can I land it, Kenneth? Sure! Comment on attachment 110890 [details] Patch Clearing flags on attachment: 110890 Committed r97398: <http://trac.webkit.org/changeset/97398> All reviewed patches have been landed. Closing bug. |