Bug 70045

Summary: Crash in DeleteSelectionCommand::handleGeneralDelete
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, morrita, ojan, tkent, tony, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fixes the crash darin: review+, rniwa: commit-queue+

Ryosuke Niwa
Reported 2011-10-13 12:22:54 PDT
Stack trace: 0x6846a438 [chrome.dll - htmlediting.cpp:976 WebCore::caretMaxOffset(WebCore::Node const *) 0x684ab73d [chrome.dll - deleteselectioncommand.cpp:420 WebCore::DeleteSelectionCommand::handleGeneralDelete() 0x684ac9b7 [chrome.dll - deleteselectioncommand.cpp:800 WebCore::DeleteSelectionCommand::doApply() 0x6847a1d2 [chrome.dll - editcommand.cpp:92 WebCore::EditCommand::apply() 0x68493734 [chrome.dll - compositeeditcommand.cpp:102 WebCore::CompositeEditCommand::applyCommandToComposite(WTF::PassRefPtr<WebCore::EditCommand>) 0x6849471c [chrome.dll - compositeeditcommand.cpp:406 WebCore::CompositeEditCommand::deleteSelection(bool,bool,bool,bool) 0x68497858 [chrome.dll - inserttextcommand.cpp:110 WebCore::InsertTextCommand::doApply() 0x6847a1d2 [chrome.dll - editcommand.cpp:92 WebCore::EditCommand::apply() 0x684937be [chrome.dll - compositeeditcommand.cpp:113 WebCore::CompositeEditCommand::applyCommandToComposite(WTF::PassRefPtr<WebCore::CompositeEditCommand>,WebCore::VisibleSelection const &) 0x6843eda3 [chrome.dll - typingcommand.cpp:397 WebCore::TypingCommand::insertTextRunWithoutNewlines(WTF::String const &,bool) 0x6843ecdb [chrome.dll - typingcommand.cpp:384 WebCore::TypingCommand::insertText(WTF::String const &,bool) 0x6843e9f0 [chrome.dll - typingcommand.cpp:307 WebCore::TypingCommand::doApply() 0x6847a1d2 [chrome.dll - editcommand.cpp:92 WebCore::EditCommand::apply() 0x6847a3a9 [chrome.dll - editcommand.cpp:224 WebCore::applyCommand(WTF::PassRefPtr<WebCore::EditCommand>) 0x6843e716 [chrome.dll - typingcommand.cpp:208 WebCore::TypingCommand::insertText(WebCore::Document *,WTF::String const &,WebCore::VisibleSelection const &,unsigned int,WebCore::TypingCommand::TextCompositionType) 0x6841d63c [chrome.dll - editor.cpp:1099 WebCore::Editor::insertTextWithoutSendingTextEvent(WTF::String const &,bool,WebCore::TextEvent *) 0x6841b4a7 [chrome.dll - editor.cpp:176 WebCore::Editor::handleTextEvent(WebCore::TextEvent *) 0x685a81f5 [chrome.dll - node.cpp:2793 WebCore::Node::defaultEventHandler(WebCore::Event *)
Attachments
fixes the crash (1.54 KB, patch)
2011-10-13 12:25 PDT, Ryosuke Niwa 		darin: review+
rniwa: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-10-13 12:25:56 PDT
Created attachment 110888 [details] fixes the crash
Ryosuke Niwa
Comment 2 2011-10-13 13:23:10 PDT
http://crbug.com/99408 We have 21 crash reports in Chromium.
Darin Adler
Comment 3 2011-10-13 13:39:51 PDT
Comment on attachment 110888 [details] fixes the crash View in context: https://bugs.webkit.org/attachment.cgi?id=110888&action=review > Source/WebCore/ChangeLog:10 > + No new tests because we don't have a reduction. Disappointing.
Ryosuke Niwa
Comment 4 2011-10-13 13:52:56 PDT
Comment on attachment 110888 [details] fixes the crash View in context: https://bugs.webkit.org/attachment.cgi?id=110888&action=review Thanks for the review. >> Source/WebCore/ChangeLog:10 >> + No new tests because we don't have a reduction. > > Disappointing. Yeah I know :(
Ryosuke Niwa
Comment 5 2011-10-13 13:57:40 PDT
Committed r97395: <http://trac.webkit.org/changeset/97395>
Note You need to log in before you can comment on or make changes to this bug.