Bug 70037

Summary: [Qt] enable qmltests for qt5
Product: WebKit Reporter: Gopal Raghavan <gopal.1.raghavan>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cshu, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
enable qmltests none

Gopal Raghavan
Reported 2011-10-13 10:40:01 PDT
qmltests seem to be disabled for some reason.
Attachments
enable qmltests (1.15 KB, patch)
2011-10-13 10:44 PDT, Gopal Raghavan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gopal Raghavan
Comment 1 2011-10-13 10:44:49 PDT
Created attachment 110875 [details] enable qmltests qmltests runs again for qt5
Chang Shu
Comment 2 2011-10-14 06:34:51 PDT
Comment on attachment 110875 [details] enable qmltests View in context: https://bugs.webkit.org/attachment.cgi?id=110875&action=review The code change is ok but better to communicate with Ossy when to land this patch. After landing, please also keep an eye on the bot: http://build.webkit.sed.hu/buildslaves/szeged-linux-22 > Source/WebKit2/ChangeLog:8 > + Qml tests seem to be disabled for some reason. This patch enables the tests by including qmltests to SUBDIRS. Please wrap the description in the future.
Chang Shu
Comment 3 2011-10-14 06:45:18 PDT
Ossy, I just r+ed this patch.
WebKit Review Bot
Comment 4 2011-10-14 07:56:55 PDT
Comment on attachment 110875 [details] enable qmltests Clearing flags on attachment: 110875 Committed r97466: <http://trac.webkit.org/changeset/97466>
WebKit Review Bot
Comment 5 2011-10-14 07:56:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.