Summary: | [CSS Regions] Change -webkit-flow to -webkit-flow-into | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihnea Ovidenie <mihnea> | ||||||||
Component: | CSS | Assignee: | Mihnea Ovidenie <mihnea> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 69752 | ||||||||||
Attachments: |
|
Description
Mihnea Ovidenie
2011-10-13 03:55:57 PDT
Created attachment 110822 [details]
Patch
Attachment 110822 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
LayoutTests/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/css/CSSParser.cpp:6512: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:6513: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:6514: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:6515: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 8 in 79 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 110825 [details]
Patch 2
Correct webkit style.
Comment on attachment 110825 [details]
Patch 2
r=me, but won't pass commit queue so clearing that. You'll need to patch the new tests as well, but assume you have a blanket r+ as long as you're just changing tests.
Created attachment 110973 [details]
Patch for landing
Comment on attachment 110973 [details] Patch for landing Clearing flags on attachment: 110973 Committed r97454: <http://trac.webkit.org/changeset/97454> All reviewed patches have been landed. Closing bug. |