Summary: | Dynamically added link-tag disables the use of change styles dynamically | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sjoerd Mulder <sjoerdmulder> | ||||||
Component: | DOM | Assignee: | Alice Liu <alice.barraclough> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Major | CC: | alice.barraclough, ddkilzer, hyatt | ||||||
Priority: | P2 | Keywords: | HasReduction, InRadar | ||||||
Version: | 420+ | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 6628 | ||||||||
Attachments: |
|
Description
Sjoerd Mulder
2006-02-01 01:56:06 PST
Created attachment 6178 [details]
Testcase
Confirmed bug. Added HasReduction keyword. This bug is also in Radar: <rdar://4432162> I tried a test case where the link tag wasn't a style sheet but just an href with the href being updated after appendChild and the flickering isn't observed. Looks like it needs to be a style sheet, but I haven't tried other types of link tags besides that one. Created attachment 7122 [details]
patch
uploading patch
hmm, i dont know if i chose the right settings when i uploaded the patch. Comment on attachment 7122 [details]
patch
Looks good. One minor style quibble... we leave braces off single-line if statements, so:
+ if (m_loading) {
+ getDocument()->stylesheetLoaded();
+ }
should lose the braces.
r=me
(In reply to comment #7) > r=me Doesn't this patch need a LayoutTest, or can this not be tested automatically? |