Bug 69937

Summary:

Web Inspector: BreakpointManager should operate on SourceMappings.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review-

Pavel Podivilov

Reported 2011-10-12 09:41:07 PDT

Web Inspector: BreakpointManager should operate on SourceMappings. Currently, the code that restores breakpoints in newly added UISourceCode is scattered between BreakpointManager and DebuggerPresentationModel. It could be moved to BreakpointManager if model will notify BreakpointManager about SourceMapping updates.

Attachments
Patch (39.75 KB, patch) 2011-10-12 09:42 PDT, Pavel Podivilov	pfeldman: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-10-12 09:42:55 PDT

Created attachment 110691 [details] Patch

Pavel Feldman

Comment 2 2011-10-16 10:46:58 PDT

Comment on attachment 110691 [details] Patch Introducing SourceMappings brings the code complexity beyond the level I feel comfortable reviewing. I think we should simplify what we have prior to adding more complexity. Is there a design doc outlining the relationships and ownership between the UISourceCode, RawSourceCode, SourceFrame and DebuggerPresentationModel? I am interested in learning the "life of a breakpoint" and how it is affected by the source mapping installation.

Note You need to log in before you can comment on or make changes to this bug.