[Qt] Missing XP_UNIX define with Qt5's qmake

• Component: Platform
• Status: RESOLVED INVALID

[Balazs Kelemen]

Qt5's qmake does not interpret Source/WebCore/features.pri correctly. It can be checked by adding the following:

diff --git a/Source/WebCore/features.pri b/Source/WebCore/features.pri
index 933069b..cd06215 100644
--- a/Source/WebCore/features.pri
+++ b/Source/WebCore/features.pri
@@ -92,6 +92,7 @@ isEmpty(HAVE_QRAWFONT) {
     unix|win32-*:!embedded:!wince*: {
         DEFINES += ENABLE_NETSCAPE_PLUGIN_API=1
     } else {
+        error(wrong_branch)
         DEFINES += ENABLE_NETSCAPE_PLUGIN_API=0
     }
 }

On Linux the then case of the branch should be active but that's not the case.
Strangely enough a small example with the same condition (unix|win32-*:!embedded:!wince*:) works correctly.
It should be fixed in qmake but maybe we need a workaround for the meantime.

[Simon Hausmann]

Did you ever manage to find out why unix|win32-*:!embedded:!wince*: doesn't work with qt5? I.e. what happens if you reduce the condition piece by piece?

[Balazs Kelemen]

(In reply to comment #1)
> Did you ever manage to find out why unix|win32-*:!embedded:!wince*: doesn't work with qt5? I.e. what happens if you reduce the condition piece by piece?

For a small example the same condition works. It seems like it is even working correctly for DerivedSources.pro. It should be a nasty qmake bug which causing the tool to goes crasy when processing WebCore.pro. However I don't think this needs a workaround for now since we should disable plugins anyway according to https://bugs.webkit.org/show_bug.cgi?id=70023.

[Balazs Kelemen]

I think we cannot reproduce it anymore, even the bug still exists in qmake.