Bug 6988
Summary: | REGRESSION: Display correct context menus for new text fields | ||
---|---|---|---|
Product: | WebKit | Reporter: | Adele Peterson <adele> |
Component: | Forms | Assignee: | Adele Peterson <adele> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | sullivan |
Priority: | P1 | Keywords: | InRadar, Regression |
Version: | 420+ | ||
Hardware: | Mac | ||
OS: | OS X 10.4 |
Adele Peterson
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Adele Peterson
<rdar://problem/4463541> Display correct context menus for new text fields (6988)
Adele Peterson
Bumping to P1 since this causes a text field regression
Maciej Stachowiak
These are all text field regressions so they should all be P1.
Darin Adler
Adele, I know you've been working on this. Could you add some notes about your progress so far?
Adele Peterson
Right now, the context menu that comes up includes:
Search in Spotlight
Search in Google
-----------------
Look Up in Dictionary
-----------------
Copy (if there's a selection)
-----------------
Inspect Element (if the default is turned on for this)
I think we want to have a menu like this:
"spelling suggestions" (if misspelled word is selected)
--------------------
Ignore Spelling (if misspelled word is selected)
Learn Spelling (if misspelled word is selected)
-------------------
Open URL (if selection looks like URL)
-------------------
Search in Spotlight
Search in Google
----------------------
Look Up in Dictionary
----------------------
Cut (dimmed at appropriate times)
Copy (dimmed at appropriate times)
Paste (dimmed at appropriate times)
----------------------
Spelling >
Speech >
-----------------
Inspect Element (if the default is turned on for this)
The menu items we'd be leaving out from existing NSTextFields would be:
Make Link, Font, Writing Direction
We have a nib for an editing context menu in WebKit right now, but Safari doesn't use that context menu (I think only Mail does). I'm not sure why we don't use that menu for contenteditable elements. I'm not sure if we'll need to add another nib specifically for the text fields or if we can somehow use the existing nib, and the existing code for the editing menu and alter it to be used for both purposes.