Bug 69875

Summary:

[Qt][WK2] Move qweberror* out of API/qt

Product:

WebKit

Reporter:

Jesus Sanchez-Palencia <jesus>

Component:

WebKit Qt

Assignee:

Jesus Sanchez-Palencia <jesus>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, kenneth, kling, menard, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jesus Sanchez-Palencia 2011-10-11 15:39:00 PDT

Since QWebError is not exposed on our API by any means, we should move it outside API/qt in order to keep our API folder (layer) aligned.

Comment 1 Jesus Sanchez-Palencia 2011-10-11 15:42:50 PDT

Created attachment 110593 [details]
Patch

Comment 2 Kenneth Rohde Christiansen 2011-10-11 15:43:56 PDT

What if we are going to use this as private api for implementing a browser etc? Or you are sure that is not needed? just wondering.

Comment 3 Jesus Sanchez-Palencia 2011-10-11 15:50:57 PDT

(In reply to comment #2)
> What if we are going to use this as private api for implementing a browser etc? Or you are sure that is not needed? just wondering.

Then it can be used in the same fashion of QtWebPageProxy, can't it?

What motivated me is the fact that we are keeping this in our "API layer" but not exposing it or not even planning to do so.

Comment 4 Andreas Kling 2011-10-12 07:55:46 PDT

Comment on attachment 110593 [details]
Patch

Right-o!

Comment 5 WebKit Review Bot 2011-10-12 08:26:15 PDT

Comment on attachment 110593 [details]
Patch

Clearing flags on attachment: 110593

Committed r97263: <http://trac.webkit.org/changeset/97263>

Comment 6 WebKit Review Bot 2011-10-12 08:26:19 PDT

All reviewed patches have been landed.  Closing bug.