Bug 69875

Summary: [Qt][WK2] Move qweberror* out of API/qt
Product: WebKit Reporter: Jesus Sanchez-Palencia <jesus>
Component: WebKit QtAssignee: Jesus Sanchez-Palencia <jesus>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, kenneth, kling, menard, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jesus Sanchez-Palencia
Reported 2011-10-11 15:39:00 PDT
Since QWebError is not exposed on our API by any means, we should move it outside API/qt in order to keep our API folder (layer) aligned.
Attachments
Patch (15.48 KB, patch)
2011-10-11 15:42 PDT, Jesus Sanchez-Palencia 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1 2011-10-11 15:42:50 PDT
Created attachment 110593 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-10-11 15:43:56 PDT
What if we are going to use this as private api for implementing a browser etc? Or you are sure that is not needed? just wondering.
Jesus Sanchez-Palencia
Comment 3 2011-10-11 15:50:57 PDT
(In reply to comment #2) > What if we are going to use this as private api for implementing a browser etc? Or you are sure that is not needed? just wondering. Then it can be used in the same fashion of QtWebPageProxy, can't it? What motivated me is the fact that we are keeping this in our "API layer" but not exposing it or not even planning to do so.
Andreas Kling
Comment 4 2011-10-12 07:55:46 PDT
Comment on attachment 110593 [details] Patch Right-o!
WebKit Review Bot
Comment 5 2011-10-12 08:26:15 PDT
Comment on attachment 110593 [details] Patch Clearing flags on attachment: 110593 Committed r97263: <http://trac.webkit.org/changeset/97263>
WebKit Review Bot
Comment 6 2011-10-12 08:26:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.