Bug 69859

Summary: [Qt][WK2] ASSERT when displaying context menu in input field
Product: WebKit Reporter: Dinu Jacob <dinu.jacob>
Component: WebKit QtAssignee: Dinu Jacob <dinu.jacob>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
hausmann: review-
Patch with ChangeLog update (Can't think of why I didn't do it earlier :) ) none

Dinu Jacob
Reported 2011-10-11 11:44:16 PDT
Right clicking in an input field to display the context menu causes an ASSERT when creating the sub menu and setting the menu as the parent of the sub-menu in WebContextMenuProxyQt::createContextMenu.
Attachments
Patch (1.38 KB, patch)
2011-10-11 11:58 PDT, Dinu Jacob 		hausmann: review-
DetailsFormatted DiffDiff
Patch with ChangeLog update (Can't think of why I didn't do it earlier :) ) (1.68 KB, patch)
2011-10-18 06:23 PDT, Dinu Jacob 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dinu Jacob
Comment 1 2011-10-11 11:47:53 PDT
QWidget is statically cast to QObject before calling setParent on it. QObject::setParent asserts if the object is a QWidget.
Dinu Jacob
Comment 2 2011-10-11 11:58:33 PDT
Created attachment 110554 [details] Patch
Dinu Jacob
Comment 3 2011-10-11 12:00:05 PDT
Patch attached. Not sure why it was being explcitly cast to QObject. I see that the setParent of QWidget does additional things than QObject. Please review and provide your feedback.
Simon Hausmann
Comment 4 2011-10-14 01:48:33 PDT
Comment on attachment 110554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110554&action=review > Source/WebKit2/UIProcess/qt/WebContextMenuProxyQt.cpp:115 > - static_cast<QObject*>(subMenu.get())->setParent(menu.get()); > + subMenu->setParent(menu.get()); Could you explain (for example in the changelog or whereever appropriate) why your patch fixes the assert? Please also mention what assert exactly :)
Simon Hausmann
Comment 5 2011-10-14 01:52:30 PDT
Argh, I should've read the bug report first, I see that the comments explain it :)
Dinu Jacob
Comment 6 2011-10-18 06:23:29 PDT
Created attachment 111429 [details] Patch with ChangeLog update (Can't think of why I didn't do it earlier :) )
WebKit Review Bot
Comment 7 2011-10-18 08:50:38 PDT
Comment on attachment 111429 [details] Patch with ChangeLog update (Can't think of why I didn't do it earlier :) ) Clearing flags on attachment: 111429 Committed r97760: <http://trac.webkit.org/changeset/97760>
WebKit Review Bot
Comment 8 2011-10-18 08:50:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.