Bug 69858

Summary: De-virtualized JSCell::toNumber
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67690    
Attachments:
Description Flags
Patch
none
Fix windows
none
Patch none

Mark Hahnenberg
Reported 2011-10-11 11:43:12 PDT
Now that the JSC C API does something more sensible for toNumber (see bug 69156), we can eliminate JSCallbackObject::toNumber in favor of simply using JSObject::toString to cover the case for JSCallbackObject.
Attachments
Patch (11.03 KB, patch)
2011-10-11 11:48 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Fix windows (11.96 KB, patch)
2011-10-11 16:47 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (12.25 KB, patch)
2011-10-12 18:39 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-10-11 11:48:16 PDT
Created attachment 110550 [details] Patch
Mark Hahnenberg
Comment 2 2011-10-11 16:47:17 PDT
Created attachment 110606 [details] Fix windows
Mark Hahnenberg
Comment 3 2011-10-12 11:10:32 PDT
*** Bug 69679 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 4 2011-10-12 14:37:54 PDT
Comment on attachment 110606 [details] Fix windows Rejecting attachment 110606 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: unk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptGlue/UserObjectImp.cpp Hunk #1 FAILED at 294. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptGlue/UserObjectImp.cpp.rej patching file Source/JavaScriptGlue/UserObjectImp.h Hunk #1 FAILED at 61. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptGlue/UserObjectImp.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10046045
Mark Hahnenberg
Comment 5 2011-10-12 18:39:38 PDT
Created attachment 110789 [details] Patch
WebKit Review Bot
Comment 6 2011-10-13 12:24:04 PDT
Comment on attachment 110789 [details] Patch Clearing flags on attachment: 110789 Committed r97381: <http://trac.webkit.org/changeset/97381>
WebKit Review Bot
Comment 7 2011-10-13 12:24:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.