De-virtualized JSCell::toNumber

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Hahnenberg]

Now that the JSC C API does something more sensible for toNumber (see bug 69156), we can eliminate JSCallbackObject::toNumber in favor of simply using JSObject::toString to cover the case for JSCallbackObject.

[Mark Hahnenberg]

Created attachment 110550 [details]
Patch

[Mark Hahnenberg]

Created attachment 110606 [details]
Fix windows

[Mark Hahnenberg]

*** Bug 69679 has been marked as a duplicate of this bug. ***

[WebKit Review Bot]

Comment on attachment 110606 [details]
Fix windows

Rejecting attachment 110606 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
unk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptGlue/UserObjectImp.cpp
Hunk #1 FAILED at 294.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptGlue/UserObjectImp.cpp.rej
patching file Source/JavaScriptGlue/UserObjectImp.h
Hunk #1 FAILED at 61.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptGlue/UserObjectImp.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10046045

[Mark Hahnenberg]

Created attachment 110789 [details]
Patch

[WebKit Review Bot]

Comment on attachment 110789 [details]
Patch

Clearing flags on attachment: 110789

Committed r97381: <http://trac.webkit.org/changeset/97381>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.