Bug 69848 – [CSS Regions]Remove -webkit-content-order property

• Component: CSS
• Status: RESOLVED FIXED

[Mihnea Ovidenie]

Latest version of the regions spec removes this property: http://dev.w3.org/csswg/css3-regions/

[Mihnea Ovidenie]

Created attachment 110530 [details]
Patch

[Tony Chang]

Comment on attachment 110530 [details]
Patch

Do you know why the patch doesn't apply?

[Mihnea Ovidenie]

Created attachment 110645 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 110645 [details]
Patch for landing

Rejecting attachment 110645 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Mihnea Ovidenie]

Created attachment 110667 [details]
Patch for landing

[Mihnea Ovidenie]

Created attachment 110670 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 110670 [details]
Patch for landing

Rejecting attachment 110670 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
tyle/computed-style-without-renderer.html = TEXT
  fast/css/getComputedStyle/computed-style.html = TEXT
  svg/css/getComputedStyle-basic.xhtml = TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/10030882

[WebKit Review Bot]

Comment on attachment 110670 [details]
Patch for landing

Rejecting attachment 110670 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
tyle/computed-style-without-renderer.html = TEXT
  fast/css/getComputedStyle/computed-style.html = TEXT
  svg/css/getComputedStyle-basic.xhtml = TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/10029934

[Tony Chang]

I'm not sure why this patch is failing.

@abarth: I thought the cq would automatically ignore the failures from not having the right fonts installed.  Do you know why that's no longer happening?

[Adam Barth]

> @abarth: I thought the cq would automatically ignore the failures from not having the right fonts installed.  Do you know why that's no longer happening?

Sorry the error messages from the commit-queue aren't very good.  It looks like this patch causes these tests to fail:

Regressions: Unexpected text diff mismatch : (3)
  fast/css/getComputedStyle/computed-style-without-renderer.html = TEXT
  fast/css/getComputedStyle/computed-style.html = TEXT
  svg/css/getComputedStyle-basic.xhtml = TEXT

[Tony Chang]

(In reply to comment #10)
> > @abarth: I thought the cq would automatically ignore the failures from not having the right fonts installed.  Do you know why that's no longer happening?
> 
> Sorry the error messages from the commit-queue aren't very good.  It looks like this patch causes these tests to fail:
> 
> Regressions: Unexpected text diff mismatch : (3)
>   fast/css/getComputedStyle/computed-style-without-renderer.html = TEXT
>   fast/css/getComputedStyle/computed-style.html = TEXT
>   svg/css/getComputedStyle-basic.xhtml = TEXT

I see, the patch is just missing the chromium baselines for these.  I guess there's no way to force the cq to land the patch and grab the baselines from the bots manually so we need to add it to LayoutTests/platform/chromium/test_expectations.txt in this patch.

[Mihnea Ovidenie]

(In reply to comment #11)
> (In reply to comment #10)
> > > @abarth: I thought the cq would automatically ignore the failures from not having the right fonts installed.  Do you know why that's no longer happening?
> > 
> > Sorry the error messages from the commit-queue aren't very good.  It looks like this patch causes these tests to fail:
> > 
> > Regressions: Unexpected text diff mismatch : (3)
> >   fast/css/getComputedStyle/computed-style-without-renderer.html = TEXT
> >   fast/css/getComputedStyle/computed-style.html = TEXT
> >   svg/css/getComputedStyle-basic.xhtml = TEXT
> 
> I see, the patch is just missing the chromium baselines for these.  I guess there's no way to force the cq to land the patch and grab the baselines from the bots manually so we need to add it to LayoutTests/platform/chromium/test_expectations.txt in this patch.

Ok, so i need to modify test_expectations.txt in this patch to mark that the above files are failing for this bug? Something like:
BUGWK69848 : fast/css/getComputedStyle/computed-style-without-renderer.html = FAIL

If this is the right approach, i will redo the patch and put it in the commit queue again.

[Tony Chang]

(In reply to comment #12)
> Ok, so i need to modify test_expectations.txt in this patch to mark that the above files are failing for this bug? Something like:
> BUGWK69848 : fast/css/getComputedStyle/computed-style-without-renderer.html = FAIL
> 
> If this is the right approach, i will redo the patch and put it in the commit queue again.

Yes, that's right.  Make sure to run new-run-webkit-tests --chromium --lint-test-files to make sure the syntax is correct.

[WebKit Review Bot]

Comment on attachment 110670 [details]
Patch for landing

Attachment 110670 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10040047

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html

[Tony Chang]

Actually, I bet I can hand edit the results.  I'll try that.

[Tony Chang]

Created attachment 110746 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 110746 [details]
Patch for landing

Clearing flags on attachment: 110746

Committed r97308: <http://trac.webkit.org/changeset/97308>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.