Bug 69836

Summary: [GTK] enable-webaudio websetting
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: donggwan.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 69835    
Bug Blocks: 61355    
Attachments:
Description Flags
WebAudio GStreamer implementation: enable-webaudio setting
none
WebAudio GStreamer implementation: enable-webaudio setting mrobinson: review+

Philippe Normand
Reported 2011-10-11 06:38:51 PDT
Like for WebGL a setting is needed to toggle WebAudio support at runtime.
Attachments
WebAudio GStreamer implementation: enable-webaudio setting (7.19 KB, patch)
2011-11-21 08:56 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
WebAudio GStreamer implementation: enable-webaudio setting (7.45 KB, patch)
2011-11-23 09:33 PST, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-11-21 08:56:35 PST
Created attachment 116097 [details] WebAudio GStreamer implementation: enable-webaudio setting
Martin Robinson
Comment 2 2011-11-21 09:18:59 PST
Comment on attachment 116097 [details] WebAudio GStreamer implementation: enable-webaudio setting View in context: https://bugs.webkit.org/attachment.cgi?id=116097&action=review > Source/WebKit/gtk/webkit/webkitwebsettings.cpp:915 > + * Enable or disable support for WebAudio on pages. You probably want to have a short description of what WebAudio is and a link to the spec.
Philippe Normand
Comment 3 2011-11-21 10:02:22 PST
Comment on attachment 116097 [details] WebAudio GStreamer implementation: enable-webaudio setting Will update this patch tomorrow, thanks for the first insight Martin
Philippe Normand
Comment 4 2011-11-23 09:33:55 PST
Created attachment 116376 [details] WebAudio GStreamer implementation: enable-webaudio setting
Martin Robinson
Comment 5 2011-12-01 01:10:30 PST
Comment on attachment 116376 [details] WebAudio GStreamer implementation: enable-webaudio setting Looks good, but we need one more person to r+ this since it's an API change.
Gustavo Noronha (kov)
Comment 6 2011-12-01 01:28:49 PST
Comment on attachment 116376 [details] WebAudio GStreamer implementation: enable-webaudio setting +1
Philippe Normand
Comment 7 2011-12-01 02:34:11 PST
Committed r101641: <http://trac.webkit.org/changeset/101641>
Note You need to log in before you can comment on or make changes to this bug.