Bug 69824

Summary:

[WebSocket] update pywebsocket to 0.6b6 which support hybi-13 protocol

Product:

WebKit

Reporter:

Takashi Toyoshima <toyoshim>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, tkent, webkit.review.bot, yutak

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Takashi Toyoshima

Reported 2011-10-11 02:03:22 PDT

Update pywebsocket to the newest one. 0.6b6 support both of current protocol version 8 and the latest protocol version 13.

Attachments
Patch (1.79 KB, patch) 2011-10-11 02:14 PDT, Takashi Toyoshima	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Takashi Toyoshima

Comment 1 2011-10-11 02:14:54 PDT

Created attachment 110489 [details] Patch

Kent Tamura

Comment 2 2011-10-11 03:18:36 PDT

Comment on attachment 110489 [details] Patch ok

WebKit Review Bot

Comment 3 2011-10-11 03:45:13 PDT

Comment on attachment 110489 [details] Patch Rejecting attachment 110489 [details] from commit-queue. toyoshim@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Takashi Toyoshima

Comment 4 2011-10-11 04:11:29 PDT

Comment on attachment 110489 [details] Patch Yuta, coud you change commit-queue status to +?

Yuta Kitamura

Comment 5 2011-10-11 05:45:29 PDT

I don't have time to watch the bots today, so I'll land this tomorrow.

WebKit Review Bot

Comment 6 2011-10-11 20:00:04 PDT

Comment on attachment 110489 [details] Patch Clearing flags on attachment: 110489 Committed r97221: <http://trac.webkit.org/changeset/97221>

WebKit Review Bot

Comment 7 2011-10-11 20:00:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.