Bug 69781

Summary: [WK2] Add a C API to inspect injected bundle path associated with a WKContextRef
Product: WebKit Reporter: Siddharth Mathur <s.mathur>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: andersca, aroben, fbqw68, kling, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch contains new API WKContextGetInjectedBundlePath to inspect injected bundle path associated with a WKContextRef
kling: review-
Updated the new patch sam: review-, fbqw68: commit-queue?

Siddharth Mathur
Reported 2011-10-10 13:49:26 PDT
It would be nice to have a API in WKContext.h which allows the path (WKStringRef) of the associated injected bundle to be inspected. I.e users of WKContextCreateWithInjectedBundlePath(WKStringRef path) should be able inspect the path at any time given only a WKContextRef.
Attachments
Patch contains new API WKContextGetInjectedBundlePath to inspect injected bundle path associated with a WKContextRef (1.88 KB, patch)
2011-10-21 04:48 PDT, Vamshikrishna Yellenki 		kling: review-
DetailsFormatted DiffDiff
Updated the new patch (1.88 KB, patch)
2011-10-21 05:23 PDT, Vamshikrishna Yellenki 		sam: review-
fbqw68: commit-queue?
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-10-10 18:10:38 PDT
This seems like an acceptable API addition to me.
Vamshikrishna Yellenki
Comment 2 2011-10-21 04:48:18 PDT
Created attachment 111943 [details] Patch contains new API WKContextGetInjectedBundlePath to inspect injected bundle path associated with a WKContextRef Patch contains new API WKContextGetInjectedBundlePath to inspect injected bundle path associated with a WKContextRef
Andreas Kling
Comment 3 2011-10-21 05:10:42 PDT
Comment on attachment 111943 [details] Patch contains new API WKContextGetInjectedBundlePath to inspect injected bundle path associated with a WKContextRef View in context: https://bugs.webkit.org/attachment.cgi?id=111943&action=review Please set r? if you want a patch to be reviewed. :) > Source/WebKit2/UIProcess/API/C/WKContext.cpp:67 > +WKStringRef WKContextGetInjectedBundlePath(WKContextRef contextRef) > +{ > + return toCopiedAPI(toImpl(contextRef)->injectedBundlePath()); > +} This should be called WKContextCopyInjectedBundlePath since it returns a copy.
Vamshikrishna Yellenki
Comment 4 2011-10-21 05:23:22 PDT
Created attachment 111950 [details] Updated the new patch
Adam Roben (:aroben)
Comment 5 2011-10-21 06:41:55 PDT
Comment on attachment 111950 [details] Updated the new patch This could use a test. You should be able to add one to TestWebKitAPI.
Sam Weinig
Comment 6 2012-01-22 14:22:06 PST
Comment on attachment 111950 [details] Updated the new patch View in context: https://bugs.webkit.org/attachment.cgi?id=111950&action=review r- for lack of test. > Source/WebKit2/UIProcess/API/C/WKContext.h:112 > +WK_EXPORT WKStringRef WKContextCopyInjectedBundlePath(WKContextRef context); This should move our of the group of create/get WKContextRef functions.
Note You need to log in before you can comment on or make changes to this bug.