Bug 69735

Summary: Fix Leopard and Snow Leopard build after changeset 97034
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+, dbates: commit-queue-

Luke Macpherson
Reported 2011-10-09 20:55:07 PDT
Fix build regressions in 97043
Attachments
Patch (3.23 KB, patch)
2011-10-09 20:57 PDT, Luke Macpherson 		dbates: review+
dbates: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-10-09 20:57:49 PDT
Created attachment 110322 [details] Patch
Daniel Bates
Comment 3 2011-10-09 21:22:27 PDT
Comment on attachment 110322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110322&action=review Will land this by hand and fix commit message. Thanks for the fix! > Source/WebCore/ChangeLog:3 > + Fix build regressions in 97043 97043 => 97034 Also, should mention the builds that this fixes, which includes Leopard and Snow Leopard.
Daniel Bates
Comment 4 2011-10-09 21:28:31 PDT
Committed r97040: <http://trac.webkit.org/changeset/97040>
Alexey Proskuryakov
Comment 5 2011-10-11 16:31:27 PDT
The BuiltInPDFView changes are not quite perfect. The new zoomAnimatorTransformChanged override was added in the midst of Plugin class methods, while there is a separate section for ScrollableArea methods below.
Alexey Proskuryakov
Comment 6 2011-10-28 12:27:40 PDT
Fixing that in bug 71133.
Note You need to log in before you can comment on or make changes to this bug.