Bug 69722

Summary: Remove unused callOperation code of DFG JIT on X86
Product: WebKit Reporter: Yuqiang Xian <yuqiang.xian>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch fpizlo: review+, webkit.review.bot: commit-queue-

Yuqiang Xian
Reported 2011-10-09 05:07:19 PDT
We'll never reach callOperation(*EJJJ*) on X86 because it requires 6 GPRs while currently DFG JIT on X86 only provides 5 GPRs. For those operations which require 3 or more JSValue arguments (like instanceof) we spill the registers and load the data into registers on demand, push the parameters and directly invoke appendCall. Removing the unused callOperation code avoids some confusions.
Attachments
the patch (1.56 KB, patch)
2011-10-09 05:11 PDT, Yuqiang Xian 		fpizlo: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuqiang Xian
Comment 1 2011-10-09 05:11:26 PDT
Created attachment 110299 [details] the patch
Filip Pizlo
Comment 2 2011-10-09 12:10:27 PDT
Comment on attachment 110299 [details] the patch Good, now I won't be confused anymore. :-)
WebKit Review Bot
Comment 3 2011-10-09 13:13:49 PDT
Comment on attachment 110299 [details] the patch Rejecting attachment 110299 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 8844d935327f1fc226a0fad08c6ed917a040bc6e r97030 = dc41f7fd22ff22f80625aa49e8a9585308c9b432 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10009788
Filip Pizlo
Comment 4 2011-10-09 15:36:32 PDT
Going to land this manually.
Filip Pizlo
Comment 5 2011-10-09 15:39:31 PDT
Landed in r97033.
Note You need to log in before you can comment on or make changes to this bug.