Bug 69720

Summary:

JSVALUE32_64 DFG JIT - fillJSValue with a pair of GPRs should not set the registerFormat to be DataFormatJSDouble

Product:

WebKit

Reporter:

Yuqiang Xian <yuqiang.xian>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, fpizlo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch	none

Description Yuqiang Xian 2011-10-09 04:21:58 PDT

In JSVALUE32_64 DFG, DataFormatJSDouble is assumed to be represented by a FPR and will be used for further optimizations, though we currently don't fully utilize it. For now when filling a JS value which was spilled as a JSDouble with a pair of GPRs, we'll set the registerFormat to DataFormatJS to avoid compilation errors.

Comment 1 Yuqiang Xian 2011-10-09 04:27:45 PDT

Created attachment 110296 [details]
the patch

Comment 2 WebKit Review Bot 2011-10-09 13:13:53 PDT

Comment on attachment 110296 [details]
the patch

Clearing flags on attachment: 110296

Committed r97031: <http://trac.webkit.org/changeset/97031>

Comment 3 WebKit Review Bot 2011-10-09 13:13:57 PDT

All reviewed patches have been landed.  Closing bug.