Bug 69637

Summary: [FileSystem API] requestFileSystem successCallback is required
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, dglazkov, ericu, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2011-10-07 10:01:55 PDT
According to http://dev.w3.org/2009/dap/file-system/pub/FileSystem/#methods , the third parameter to requestFileSystem (successCallback) is not optional and can not be null. This test attempts to call the method without this parameter and checks for the required TypeError. Expected behavior: TypeError: not enough arguments Actual behavior: no exception thrown
Attachments
Patch (2.08 KB, patch)
2011-10-07 10:10 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (4.04 KB, patch)
2011-12-02 13:38 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (5.14 KB, patch)
2011-12-07 13:51 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-10-07 10:10:49 PDT
Created attachment 110164 [details] Patch
WebKit Review Bot
Comment 2 2011-10-07 10:54:47 PDT
Comment on attachment 110164 [details] Patch Attachment 110164 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10015095 New failing tests: fast/filesystem/simple-required-arguments.html
Mark Pilgrim (Google)
Comment 3 2011-10-07 10:59:03 PDT
Whoops, obviously these shouldn't have the review flag set since they are known failing tests.
Darin Adler
Comment 4 2011-10-10 14:20:04 PDT
(In reply to comment #3) > Whoops, obviously these shouldn't have the review flag set since they are known failing tests. It’s OK to land an expected failing result. The patch that fixes the bug just patches the expectation file to expect success instead of failure. We could group more of these tests in a single file, too, by the way. I think the tests are pretty clear even if there are a lot of them all in one test file.
Mark Pilgrim (Google)
Comment 5 2011-12-02 13:38:16 PST
Created attachment 117678 [details] Patch
WebKit Review Bot
Comment 6 2011-12-02 19:43:24 PST
Comment on attachment 117678 [details] Patch Attachment 117678 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10729255 New failing tests: fast/filesystem/filesystem-no-callback-null-ptr-crash.html
Mark Pilgrim (Google)
Comment 7 2011-12-07 13:51:28 PST
Created attachment 118271 [details] Patch
WebKit Review Bot
Comment 8 2011-12-07 19:55:49 PST
Comment on attachment 118271 [details] Patch Clearing flags on attachment: 118271 Committed r102305: <http://trac.webkit.org/changeset/102305>
WebKit Review Bot
Comment 9 2011-12-07 19:55:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.