Bug 69637

Summary:

[FileSystem API] requestFileSystem successCallback is required

Product:

WebKit

Reporter:

Mark Pilgrim (Google) <pilgrim>

Component:

New Bugs

Assignee:

Mark Pilgrim (Google) <pilgrim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, dglazkov, ericu, ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Mark Pilgrim (Google) 2011-10-07 10:01:55 PDT

According to http://dev.w3.org/2009/dap/file-system/pub/FileSystem/#methods , the third parameter to requestFileSystem (successCallback) is not optional and can not be null. This test attempts to call the method without this parameter and checks for the required TypeError.

Expected behavior: TypeError: not enough arguments
Actual behavior: no exception thrown

Comment 1 Mark Pilgrim (Google) 2011-10-07 10:10:49 PDT

Created attachment 110164 [details]
Patch

Comment 2 WebKit Review Bot 2011-10-07 10:54:47 PDT

Comment on attachment 110164 [details]
Patch

Attachment 110164 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10015095

New failing tests:
fast/filesystem/simple-required-arguments.html

Comment 3 Mark Pilgrim (Google) 2011-10-07 10:59:03 PDT

Whoops, obviously these shouldn't have the review flag set since they are known failing tests.

Comment 4 Darin Adler 2011-10-10 14:20:04 PDT

(In reply to comment #3)
> Whoops, obviously these shouldn't have the review flag set since they are known failing tests.

It’s OK to land an expected failing result. The patch that fixes the bug just patches the expectation file to expect success instead of failure.

We could group more of these tests in a single file, too, by the way. I think the tests are pretty clear even if there are a lot of them all in one test file.

Comment 5 Mark Pilgrim (Google) 2011-12-02 13:38:16 PST

Created attachment 117678 [details]
Patch

Comment 6 WebKit Review Bot 2011-12-02 19:43:24 PST

Comment on attachment 117678 [details]
Patch

Attachment 117678 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10729255

New failing tests:
fast/filesystem/filesystem-no-callback-null-ptr-crash.html

Comment 7 Mark Pilgrim (Google) 2011-12-07 13:51:28 PST

Created attachment 118271 [details]
Patch

Comment 8 WebKit Review Bot 2011-12-07 19:55:49 PST

Comment on attachment 118271 [details]
Patch

Clearing flags on attachment: 118271

Committed r102305: <http://trac.webkit.org/changeset/102305>

Comment 9 WebKit Review Bot 2011-12-07 19:55:54 PST

All reviewed patches have been landed.  Closing bug.