Bug 69627 – change backtrace notation

• Component: New Bugs
• Status: RESOLVED WONTFIX

[Gavin Peters]

change backtrace notation

[Gavin Peters]

Created attachment 110145 [details]
Patch

[Gavin Peters]

Comment on attachment 110145 [details]
Patch

Here, separated out from my regression fix yesterday, are some updates to backtrace notation.  Gavin suggested the inverted numbering; after playing with it for a while I agree with his reasoning: it is easier to compare two backtraces when they are numbered like this.  On my machine, __libc_main is always 3, etc... etc...

The proposed numbering is inconsistent with how gdb refers to stack frames as well as how they are numbered in OS X crash reports. This can be really confusing.

[Gavin Peters]

Yes, it is inverted from almost every other tool I've seen.  gdb numbers as 0, 1, ... to terminus.

The increase of the framesToShow was also important to make the inverted numbering working; when inverted numbering is clipped, you lose the ability to compare successive stack traces, since they'll start where they're clipped, and not at main.

Gavin, WDYT?  Can this circle be squared?  Perhaps two numbering columns, the first # prefixed and increasing, the second decreasing?  That's almost more confusing...

[Gavin Peters]

Gavin Barraclaugh hasn't stepped up to defend this change, which I made at his request, so I'm closing it WONTFIX.

[Eric Seidel (no email)]

Comment on attachment 110145 [details]
Patch

Cleared review? from attachment 110145 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).