Summary: | WKTR needs to implement layoutTestController.setPageVisibility() | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
Component: | Tools / Tests | Assignee: | Jesus Sanchez-Palencia <jesus> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | gustavo.noronha, gustavo, jesus, pnormand, webkit.review.bot, xan.lopez, zarvai | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 81154, 83263, 86731 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-10-06 13:29:13 PDT
Created attachment 131936 [details]
Patch
Created attachment 133371 [details]
Patch
Comment on attachment 133371 [details] Patch Attachment 133371 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12122232 Comment on attachment 133371 [details] Patch Attachment 133371 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12116369 Comment on attachment 133371 [details] Patch Attachment 133371 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12123321 Comment on attachment 133371 [details] Patch Attachment 133371 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12122292 Created attachment 135599 [details]
Patch
Comment on attachment 135599 [details] Patch Attachment 135599 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12327003 Comment on attachment 135599 [details] Patch Attachment 135599 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12327029 Created attachment 135643 [details]
Patch
Comment on attachment 135643 [details] Patch Clearing flags on attachment: 135643 Committed r113235: <http://trac.webkit.org/changeset/113235> All reviewed patches have been landed. Closing bug. It seems this patch broke some test with Qt WK2 bots: fast/events/page-visibility-transition-test.html fast/events/page-visibility-iframe-propagation-test.html http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r113305%20%28798%29/results.html (In reply to comment #13) > It seems this patch broke some test with Qt WK2 bots: > fast/events/page-visibility-transition-test.html > fast/events/page-visibility-iframe-propagation-test.html > > http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/r113305%20%28798%29/results.html I will have a look, thanks. At a first glance, I don't get how the other Page Visibility layout tests can be working and these ones not if they all make use of the same layouttestcontroller functions... |