Bug 69529

Summary:

Web Inspector: add Styles and Metrics sidebars to the compilation.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Pavel Feldman

Reported 2011-10-06 08:56:29 PDT

Patch to follow.

Attachments
Patch (31.40 KB, patch) 2011-10-06 08:59 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-10-06 08:59:53 PDT

Created attachment 109965 [details] Patch

Yury Semikhatsky

Comment 2 2011-10-06 09:09:51 PDT

Comment on attachment 109965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109965&action=review > Source/WebCore/inspector/front-end/inspector.js:516 > + WebInspector.CSSCompletions.requestCSSNameCompletions(); This shouldn't be called every time, e.g. workers don't need this.

Pavel Feldman

Comment 3 2011-10-06 09:18:36 PDT

(In reply to comment #2) > (From update of attachment 109965 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109965&action=review > > > Source/WebCore/inspector/front-end/inspector.js:516 > > + WebInspector.CSSCompletions.requestCSSNameCompletions(); > > This shouldn't be called every time, e.g. workers don't need this. We'll sort it out when we go through the doLoadedDone for workers.

Pavel Feldman

Comment 4 2011-10-06 09:31:09 PDT

Committed r96817: <http://trac.webkit.org/changeset/96817>

Note You need to log in before you can comment on or make changes to this bug.