Summary: | ASSERT(!m_transparencyCount) in GraphicsContext::~GraphicsContext | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alejandro G. Castro <alex> | ||||
Component: | WebKitGTK | Assignee: | Sergio Villar Senin <svillar> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hyatt, jchaffraix, mrobinson, pnormand, simon.fraser, svillar, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Linux | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 69523 | ||||||
Attachments: |
|
Description
Alejandro G. Castro
2011-10-06 03:35:21 PDT
Alex it isn't crashing for me anymore. Could you confirm that? It still crashes in my desktop but it does not crash in my laptop, not sure why. Probably I should check this one in my desktop. (In reply to comment #2) > It still crashes in my desktop but it does not crash in my laptop, not sure why. Probably I should check this one in my desktop. I'll take a look since it's consistently asserting for me in debug builds. Julien is this the same crash than the one you observed on mac when adding tests for https://bugs.webkit.org/show_bug.cgi?id=68133 ? (In reply to comment #4) > Julien is this the same crash than the one you observed on mac when adding tests for https://bugs.webkit.org/show_bug.cgi?id=68133 ? It's not exactly the same (see bug 68566): it is ASSERT(m_stack.isEmpty()) that is triggered in ~GraphicsContext. It may related though. Created attachment 115181 [details]
Patch
There are also some tests skipped in WebKit1. I believe Philippe skipped these tests. Your patch should unskip them as well. Adding some reviewers with good knowledge of that code. *** Bug 71454 has been marked as a duplicate of this bug. *** Comment on attachment 115181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115181&action=review > Source/WebCore/rendering/InlineFlowBox.cpp:1286 > + if (pushTransparencyLayer) > + paintInfo.context->endTransparencyLayer(); It would be nice if we had an RAII class for begin/endTransparencyLayer. Committed r100413: <http://trac.webkit.org/changeset/100413> |