Bug 69490

Summary: Make zoom multiplier float instead of double to match RenderStyle::effectiveZoom etc. and thus avoid unnecessary precision conversions.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dbates, kling, koivisto, macpherson, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Luke Macpherson
Reported 2011-10-05 17:34:45 PDT
Make zoom multiplier float instead of double to match RenderStyle::effectiveZoom etc. and thus avoid unnecessary precision conversions.
Attachments
Patch (5.68 KB, patch)
2011-10-05 17:36 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.10 KB, patch)
2012-01-22 17:05 PST, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-10-05 17:36:39 PDT
Created attachment 109891 [details] Patch
Luke Macpherson
Comment 2 2011-10-05 17:49:27 PDT
The motivation for this was seeing cycles wasted in the profiler output doing precision conversion from float to double. This is especially wasteful because the value is later discarded when zoom is 1.0.
Luke Macpherson
Comment 3 2011-10-06 20:28:31 PDT
FYI, the performance difference isn't noticeable on PerformanceTests/Parser/html5-full-render.html ToT: Testing 6092696 byte document in 13 500000 byte chunks. Running 20 times Ignoring warm-up run (43051) 42380 42317 42440 42383 42279 42400 42350 42404 42390 42406 42224 42464 42225 42859 42056 42281 42751 42235 42230 42451 avg 42376.25 median 42381.5 stdev 174.0677669759683 min 42056 max 42859 With float patch: Testing 6092696 byte document in 13 500000 byte chunks. Running 20 times Ignoring warm-up run (42785) 42227 42249 42308 42343 42462 42386 42531 42521 42463 42367 42502 42122 42512 42245 42244 42572 42313 42514 42091 42463 avg 42371.75 median 42376.5 stdev 139.20735433158694 min 42091 max 42572
Andreas Kling
Comment 4 2012-01-20 10:24:17 PST
Comment on attachment 109891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109891&action=review r=me assuming this still applies. > Source/WebCore/ChangeLog:16 > + Change type signatures of computeLenght template prototype. Typo, computeLength.
Luke Macpherson
Comment 5 2012-01-22 17:05:26 PST
Created attachment 123503 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-01-23 18:36:38 PST
Comment on attachment 123503 [details] Patch for landing Clearing flags on attachment: 123503 Committed r105678: <http://trac.webkit.org/changeset/105678>
WebKit Review Bot
Comment 7 2012-01-23 18:36:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.