Bug 69481 – The GTK+ WebKit2 headers produce a lot of style warnings

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Martin Robinson]

We should be smarter about what warnings we emit for what files.

[Martin Robinson]

Created attachment 109886 [details]
Patch

[Carlos Garcia Campos]

*** Bug 65179 has been marked as a duplicate of this bug. ***

[Martin Robinson]

Comment on attachment 109886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109886&action=review

> Tools/Scripts/webkitpy/style/checker_unittest.py:317
> +        # Check unskipped files

This comment is missing a period. Assuming this pach is r+'d I will fix it before landing.

[Daniel Bates]

Comment on attachment 109886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109886&action=review

> Tools/Scripts/webkitpy/style/checker.py:468
> +    def _should_skip_file_path(self, file_path, skip_array_entry):

Nit: The body of this function looks like it was indented too much. The indentation for the first if-statement should be four space characters.

> Tools/Scripts/webkitpy/style/checker.py:469
> +            if isinstance(skip_array_entry, re._pattern_type):

Is there some other way we can accomplish instead of type checking or using non-public API (*)?

(*) From my understanding of Python conventions, anything that begins with an underscore ('_') isn't part of the public API and hence its existence isn't guaranteed in future versions.

>> Tools/Scripts/webkitpy/style/checker_unittest.py:317
>> +        # Check unskipped files
> 
> This comment is missing a period. Assuming this pach is r+'d I will fix it before landing.

Nit: I think "non-skipped" better describes this than "unskipped". "Unskipped files" implies to me that we chose to skip these files at some point in time, but now we're reverting that decision. The phrase "non-skipped files" implies that these are files we always warned about (i.e. these were the files that we didn't skip).

[David Levin]

Comment on attachment 109886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109886&action=review

Just one comment beyond what Daniel said (whose comments I agree with).  Thanks Daniel!

> Tools/Scripts/webkitpy/style/checker.py:285
> +    re.compile('Source/WebKit2/UIProcess/API/gtk/WebKit(?!.*Private.h).*.h$'),

Should be:
  re.compile(r'Source/WebKit2/UIProcess/API/gtk/WebKit(?!.*Private\.h).*\.h$'),

[Martin Robinson]

Created attachment 110036 [details]
Patch

[Martin Robinson]

Comment on attachment 110036 [details]
Patch

Thank you both for the prompt and thorough reviews.

[WebKit Review Bot]

Comment on attachment 110036 [details]
Patch

Clearing flags on attachment: 110036

Committed r96866: <http://trac.webkit.org/changeset/96866>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.