Summary: | [GTK][V8] Add JSC compilation option to configure.ac | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nayan Kumar K <nayankk> | ||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, mrobinson, roger.wang, webkit.review.bot, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Linux | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 32452 | ||||||||||||
Attachments: |
|
Description
Nayan Kumar K
2011-10-05 15:03:43 PDT
Created attachment 109869 [details]
Configure JSC or V8
Comment on attachment 109869 [details] Configure JSC or V8 View in context: https://bugs.webkit.org/attachment.cgi?id=109869&action=review Looks good, just one thing to fix before landing, thanks! > GNUmakefile.am:199 > +if USE_JSC > +global_cppflags += \ > + -DWTF_USE_JSC=1 > +endif > + This define is not used yet, right? If not it should be introduced in the first patch that will use it. Created attachment 109935 [details]
Configure JSC or V8
Incorporated the review comments.
Attachment 109935 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'GNUmakefile.am', u'configure..." exit_code: 1
configure.ac:854: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 109938 [details]
Resolved style issues
Attachment 109938 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'GNUmakefile.am', u'configure..." exit_code: 1
ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 109940 [details]
Configure JSC or V8
Comment on attachment 109940 [details]
Configure JSC or V8
I thought you'd land the previous patch yourself since you initially didn't flip the cq? flag.
Comment on attachment 109940 [details] Configure JSC or V8 Clearing flags on attachment: 109940 Committed r96808: <http://trac.webkit.org/changeset/96808> All reviewed patches have been landed. Closing bug. I don't understand what's the point of having this upstream when we haven't decided yet whether we'll allow V8 as an option or not. IMHO it only adds confusion for no gain at all. When (or if) a decision is made we can just land it, it's not a difficult patch at all. (In reply to comment #11) > I don't understand what's the point of having this upstream when we haven't decided yet whether we'll allow V8 as an option or not. IMHO it only adds confusion for no gain at all. When (or if) a decision is made we can just land it, it's not a difficult patch at all. I have started a discussion in mailing list to see community is willing to accept this work at this point of time. If we conclude not to push this work right now, we will revert this patch. :). Please feel free to share your opinions. Thanks. |