Summary: | media/video-loop.html is failing on Lion because of negative currentTime() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 67509 | ||||||
Attachments: |
|
Description
Jer Noble
2011-10-05 14:57:56 PDT
Actually, after digging into this, only video-loop.html is being affected by the negative-time problem. Created attachment 110017 [details]
Patch
Comment on attachment 110017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110017&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:435 > + float seconds = narrowPrecisionToFloat(CMTimeGetSeconds(itemTime)); > + return max(seconds, 0.0f); Should not need a local variable for this. Probably reads better without it. (In reply to comment #3) > (From update of attachment 110017 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110017&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:435 > > + float seconds = narrowPrecisionToFloat(CMTimeGetSeconds(itemTime)); > > + return max(seconds, 0.0f); > > Should not need a local variable for this. Probably reads better without it. You're right; I was thinking of the MAX macro. I'll change this. Thanks! Committed r97093: <http://trac.webkit.org/changeset/97093> |