Bug 69417

Summary: WTR needs an implementation for eventSender.continuousMouseScrollBy
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jdapena
Priority: P3 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88070    
Attachments:
Description Flags
Patch none

Description Balazs Kelemen 2011-10-05 06:47:46 PDT
Skip dependent tests until that.
Comment 1 Balazs Kelemen 2011-10-05 06:53:54 PDT
Skipped a test in http://trac.webkit.org/changeset/96699
Comment 2 José Dapena Paz 2012-06-06 07:19:20 PDT
Created attachment 146019 [details]
Patch
Comment 3 Balazs Kelemen 2012-06-06 10:29:32 PDT
Comment on attachment 146019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146019&action=review

Generally looks good, but there are some things to complain about.

> Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:33
> +        void continuousMouseScrollBy (in long x, in long y, in [Optional] boolean paged);

Extra space after function name.

> Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:395
> +    gdk_event_set_device(event, gdk_device_manager_get_client_pointer(gdk_display_get_device_manager(gdk_window_get_display(event->scroll.window))));
> +
> +    // For more than one tick in a scroll, we need smooth scroll event
> +#if GTK_CHECK_VERSION(3, 3, 18)
> +    if ((horizontal && vertical) || horizontal > 1 || horizontal < -1 || vertical > 1 || vertical < -1) {
> +        event->scroll.direction = GDK_SCROLL_SMOOTH;
> +        event->scroll.delta_x = -horizontal;
> +        event->scroll.delta_y = -vertical;
> +
> +        sendOrQueueEvent(event);
> +        return;
> +    }
> +#endif

Why did you have to change on this function? It was already there. Please describe it in the changelog.

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:401
> +void EventSenderProxy::continuousScrollBy(int x, int y, bool paged)
> +{

Why is it not continuousMouseScrollBy? Have you build it on Mac?
Comment 4 José Dapena Paz 2012-09-07 08:17:33 PDT
Fix for #88070 already includes the changes for WebKitTestRunner.
Comment 5 Eric Seidel (no email) 2012-10-08 16:12:04 PDT
Comment on attachment 146019 [details]
Patch

Cleared review? from attachment 146019 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).