Bug 69387

Summary: Wean ContentSecurityPolicy from the Document
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+, webkit.review.bot: commit-queue-

Description Sam Weinig 2011-10-04 17:09:33 PDT
Wean ContentSecurityPolicy from the Document
Comment 1 Sam Weinig 2011-10-04 17:12:02 PDT
Created attachment 109720 [details]
Patch
Comment 2 Adam Barth 2011-10-04 17:19:46 PDT
Comment on attachment 109720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109720&action=review

> Source/WebCore/dom/Document.h:615
> +    virtual void disableEval();

Do we have the OVERRIDE keyword from clang available?  This is a classic use case.
Comment 3 Adam Barth 2011-10-04 17:20:48 PDT
Comment on attachment 109720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109720&action=review

> Source/WebCore/page/ContentSecurityPolicy.cpp:507
>          return;

You can move a bunch of the code above this line down to the report section.
Comment 4 WebKit Review Bot 2011-10-04 17:45:56 PDT
Comment on attachment 109720 [details]
Patch

Attachment 109720 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9959016
Comment 5 Sam Weinig 2011-10-04 17:51:48 PDT
Committed r96667: <http://trac.webkit.org/changeset/96667>