Bug 69344

Summary: WKPreferences should allow control of application chrome mode
Product: WebKit Reporter: Jeff Miller <jeffm>
Component: WebKit2Assignee: Jeff Miller <jeffm>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Jeff Miller
Reported 2011-10-04 10:02:50 PDT
WebKit2 needs the equivalent of WebPreferences' setApplicationChromeModeEnabled() in WebKit1.
Attachments
Patch (3.78 KB, patch)
2011-10-04 10:39 PDT, Jeff Miller 		no flags
DetailsFormatted DiffDiff
Patch (3.83 KB, patch)
2011-10-04 11:06 PDT, Jeff Miller 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeff Miller
Comment 1 2011-10-04 10:39:29 PDT
Created attachment 109644 [details] Patch
mitz
Comment 2 2011-10-04 10:41:26 PDT
Comment on attachment 109644 [details] Patch I think this should be declared in WKPreferencesPrivate.h (the WebKit1 equivalent is in WebPreferencesPrivate.h).
Jeff Miller
Comment 3 2011-10-04 10:57:05 PDT
(In reply to comment #2) > (From update of attachment 109644 [details]) > I think this should be declared in WKPreferencesPrivate.h (the WebKit1 equivalent is in WebPreferencesPrivate.h). Whoops, I missed that, you're right.
Jeff Miller
Comment 4 2011-10-04 11:06:41 PDT
Created attachment 109652 [details] Patch
Jeff Miller
Comment 5 2011-10-04 11:14:38 PDT
Committed r96619: <http://trac.webkit.org/changeset/96619>
Note You need to log in before you can comment on or make changes to this bug.