Bug 69327

Summary: Web Inspector: remove dependency from GoToLine dialog from Panel.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported 2011-10-04 01:53:52 PDT
Patch to follow.
Attachments
Patch (9.94 KB, patch)
2011-10-04 02:09 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-10-04 02:09:23 PDT
Created attachment 109597 [details] Patch
Yury Semikhatsky
Comment 2 2011-10-04 02:14:16 PDT
Comment on attachment 109597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109597&action=review > Source/WebCore/inspector/front-end/GoToLineDialog.js:84 > + if (!sourceView || !sourceView.canHighlightLine()) !sourceView check is redundant, please remove.
Pavel Feldman
Comment 3 2011-10-04 02:16:18 PDT
Committed r96577: <http://trac.webkit.org/changeset/96577>
Note You need to log in before you can comment on or make changes to this bug.