Bug 69323

Summary:

watchlist: Add more rules for chromium public api and sort the file.

Product:

WebKit

Reporter:

David Levin <levin>

Component:

Tools / Tests

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

69303

Bug Blocks:

Attachments:

Description	Flags
Patch	abarth: review+

Description David Levin 2011-10-04 00:08:23 PDT

See summary.

Comment 1 David Levin 2011-10-04 00:09:38 PDT

It would be best if bug 69303 were fixed before this change is checked in.

Comment 2 David Levin 2011-10-04 00:10:36 PDT

Created attachment 109586 [details]
Patch

Comment 3 Adam Barth 2011-10-04 10:51:24 PDT

Comment on attachment 109586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109586&action=review

> Tools/Scripts/webkitpy/common/config/watchlist:31
> +        "ChromiumPublicApi": [ "Please wait for approval from darin@chromium.org before submitting "

darin@chromium.org => fishd@chromium.org

> Tools/Scripts/webkitpy/common/config/watchlist:32
> +                               "because this patch contains changes to the Chromium public api.", ],

api => API.

Comment 4 David Levin 2011-10-05 02:28:48 PDT

Addressed comments and committed as http://trac.webkit.org/changeset/96688