Bug 69301 – [Chromium] WebFileChooserParams needs a value to specify a "Save As" dialog.

• Component: Platform
• Status: RESOLVED FIXED

[Bill Budge]

Adds a field, "saving", to present the file chooser dialog in "Save As" mode (allows the user to choose a possibly non-existent file or directory).

[Bill Budge]

Created attachment 109544 [details]
Proposed Patch

This is used by PPB_FileChooser_Impl to specify the dialog's mode. So to implement 'SaveAs' we'll need this change.

[Darin Fisher (:fishd, Google)]

Comment on attachment 109544 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109544&action=review

> Source/WebKit/chromium/public/WebFileChooserParams.h:47
> +    bool saving;

I struggle a bit with the wording here.  I considered suggesting "saveAs".  Then
at least you could say "saveAs" chooser, just as you can say "multiSelect" chooser
or "directory" chooser.  I'm not sure though.

I feel like the properties here should either describe the dialog or the resulting
file(s).  The other existing property names are not so great.

I can imagine something like {return,select,choose}{Multiple,Directory,Writable}
might be nice.  Those would very clearly describe the file(s) being returned.

Anyways, maybe that's just fodder for a future patch as changes like that would
be pretty out-of-scope for what you are trying to do now.

I think there are still some details to work out about what it means to return
a writable file as a result of presenting a "save as" dialog.

[Bill Budge]

Created attachment 109975 [details]
Proposed Patch

My first thought was to name it 'saveAs' and probably that's better. My second thought was that 'saving' was a little prettier. I've changed it back to 'saveAs' and also fixed the license and a few other comments as well.

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[WebKit Review Bot]

Comment on attachment 109975 [details]
Proposed Patch

Rejecting attachment 109975 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
f4972aa6d2bdb3722a5d9e3757eb399c682deaa9
r96835 = fcda564b0a1d32358131790ee6e3524adb70b465
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9976287

[Bill Budge]

Created attachment 110027 [details]
Proposed Patch

Sorry Darin, I'm juggling 2 patches and missed the ChangeLog. I need to learn git.

[WebKit Review Bot]

Comment on attachment 110027 [details]
Proposed Patch

Clearing flags on attachment: 110027

Committed r96910: <http://trac.webkit.org/changeset/96910>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.