Summary: | AX: click point for AXHeadings often returns point on empty space (results in wrong context menu) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
chris fleizach
2011-10-03 08:41:10 PDT
Created attachment 109492 [details]
patch
Comment on attachment 109492 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=109492&action=review > Source/WebCore/accessibility/AccessibilityObject.h:-510 > - virtual LayoutPoint clickPoint() const; You should mention in the ChangeLog why you had to remove the const. I presume you did so because AccessibilityObject::children() is non-const? Could you change AccessibilityObject::children() to be const instead? (In reply to comment #2) > (From update of attachment 109492 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109492&action=review > > > Source/WebCore/accessibility/AccessibilityObject.h:-510 > > - virtual LayoutPoint clickPoint() const; > > You should mention in the ChangeLog why you had to remove the const. I presume you did so because AccessibilityObject::children() is non-const? Could you change AccessibilityObject::children() to be const instead? children() ensures that the objects children are up to date when called so it would be risky to change that to non-const. I will add a comment why it was changed. I'll start thinking about how to possibly make children() const > http://trac.webkit.org/changeset/96520 You don't seem to have landed the tests for this patch in http://trac.webkit.org/changeset/96520 (In reply to comment #5) > > http://trac.webkit.org/changeset/96520 > > You don't seem to have landed the tests for this patch in http://trac.webkit.org/changeset/96520 Fixed in http://trac.webkit.org/changeset/96522 |