Bug 69262 – AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

With VoiceOver, if you move to a heading (<h*> tag) and then try to open the contextual menu, often you will open a contextual menu on empty white space

that's because the click point is the mid point while the content of the heading is much smaller

[chris fleizach]

Created attachment 109492 [details]
patch

[John Sullivan]

Comment on attachment 109492 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109492&action=review

> Source/WebCore/accessibility/AccessibilityObject.h:-510
> -    virtual LayoutPoint clickPoint() const;

You should mention in the ChangeLog why you had to remove the const. I presume you did so because AccessibilityObject::children() is non-const? Could you change AccessibilityObject::children() to be const instead?

[chris fleizach]

(In reply to comment #2)
> (From update of attachment 109492 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109492&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.h:-510
> > -    virtual LayoutPoint clickPoint() const;
> 
> You should mention in the ChangeLog why you had to remove the const. I presume you did so because AccessibilityObject::children() is non-const? Could you change AccessibilityObject::children() to be const instead?

children() ensures that the objects children are up to date when called so it would be risky to change that to non-const. I will add a comment why it was changed. I'll start thinking about how to possibly make children() const

[chris fleizach]

http://trac.webkit.org/changeset/96520

[Adam Barth]

> http://trac.webkit.org/changeset/96520

You don't seem to have landed the tests for this patch in http://trac.webkit.org/changeset/96520

[chris fleizach]

(In reply to comment #5)
> > http://trac.webkit.org/changeset/96520
> 
> You don't seem to have landed the tests for this patch in http://trac.webkit.org/changeset/96520

Fixed in

http://trac.webkit.org/changeset/96522