Bug 6926

Summary: iframe.contentDocument returns 'undefined' when hidden by style 'display: none' (Bugzilla "Edit Attachment As Comment" feature does not work)
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bugs-webkit, ian
Priority: P2 Keywords: HasReduction
Version: 417.x   
Hardware: Mac   
OS: OS X 10.4   
See Also: https://bugs.webkit.org/show_bug.cgi?id=107236
https://bugs.webkit.org/show_bug.cgi?id=13118
Attachments:
Description Flags
Test case none

David Kilzer (:ddkilzer)
Reported 2006-01-29 21:25:30 PST
Steps to reproduce: 1. Open Bug 6900. 2. Click on "Edit" link next to patch attachment. 3. Click on "Edit Attachment As Comment". Expected: The "Comment (on the bug)" textarea is hidden and the diff in the window is replaced by the same diff with quote (">") characters on the first line. (See behavior in Firefox 1.5.) Actual: A JavaScript error occurs (see JavaScript Console): Undefined value http://bugzilla.opendarwin.org/attachment.cgi?id=6062&action=edit Line: 235
Attachments
Test case (745 bytes, text/html)
2006-02-04 21:08 PST, David Kilzer (:ddkilzer) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-01-29 21:30:04 PST
Note that other types of attachments (such as text/html) behave differently, although they still don't work as expected, either. See Bug 6916 for a text/html attachment.
David Kilzer (:ddkilzer)
Comment 2 2006-02-04 21:08:47 PST
Created attachment 6256 [details] Test case An <iframe></iframe> element that is hidden with style "display: none;" still has content, but iframeElement.contentDocument returns an undefined value when the iframe is hidden.
David Kilzer (:ddkilzer)
Comment 3 2006-02-04 21:13:28 PST
Updating Summary to match the issue. Changed NeedsReduction keyword to HasReduction. Same bug occurs in Safari 2.0.3 (417.8) on 10.4.4, so it's not a regression. Test case works in Firefox 1.5.0.1. MSIE 6 does not have an XMLSerializer object, so this feature of Bugzilla is not even enabled in it.
Alexey Proskuryakov
Comment 4 2006-02-05 00:06:08 PST
Sounds closely related to bug 3581. I'm re-adding the original summary, to make this issue easier to find.
David Kilzer (:ddkilzer)
Comment 5 2006-06-11 05:12:30 PDT
(In reply to comment #0) > Steps to reproduce: > > 1. Open Bug 6900. > 2. Click on "Edit" link next to patch attachment. > 3. Click on "Edit Attachment As Comment". The current version of Bugzilla on http://bugzilla.opendarwin.org/ seems to have worked around this Safari issue. However, the test case (Attachment 6256 [details]) still does not work in WebKit r14810 today.
David Kilzer (:ddkilzer)
Comment 6 2006-12-24 17:55:22 PST
This was fixed a while ago. Not sure what fixed it, though.
Alexey Proskuryakov
Comment 7 2006-12-24 21:32:25 PST
Probably, bug 3581.
Note You need to log in before you can comment on or make changes to this bug.