Bug 69253

Summary: Web Inspector: more compilation fixes including making ConsoleMessage a part of console model.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[Patch] Review comments addressed yurys: review+

Pavel Feldman
Reported 2011-10-03 05:19:23 PDT
Patch to follow.
Attachments
Patch (31.72 KB, patch)
2011-10-03 05:42 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] Review comments addressed (35.19 KB, patch)
2011-10-03 07:28 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-10-03 05:42:54 PDT
Created attachment 109474 [details] Patch
Yury Semikhatsky
Comment 2 2011-10-03 06:59:37 PDT
Comment on attachment 109474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109474&action=review > Source/WebCore/inspector/Inspector.json:555 > + { "name": "requestKey3", "type": "string", "description": "HTTP response status text." }, What is requestKey3, please chose a better name. > Source/WebCore/inspector/front-end/ConsoleMessage.js:49 > +WebInspector.ConsoleMessageImpl = function(source, type, level, line, url, repeatCount, message, parameters, stackTrace, request) Let's extract UI-independent parts of the ConsoleMessageImpl into ConsoleMessage as agreed offline.
Pavel Feldman
Comment 3 2011-10-03 07:28:07 PDT
Created attachment 109481 [details] [Patch] Review comments addressed
Yury Semikhatsky
Comment 4 2011-10-03 07:44:40 PDT
Comment on attachment 109481 [details] [Patch] Review comments addressed View in context: https://bugs.webkit.org/attachment.cgi?id=109481&action=review > Source/WebCore/inspector/front-end/ConsoleModel.js:119 > msg.repeatCount = msg.repeatCount + msg.repeatDelta; Setters for these fields are missing in ConsoleMessage.
Pavel Feldman
Comment 5 2011-10-03 07:55:35 PDT
Committed r96499: <http://trac.webkit.org/changeset/96499>
Note You need to log in before you can comment on or make changes to this bug.