Bug 69229

Summary: [Chromium] Moved files towards GTK removal
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: New BugsAssignee: Fady Samuel <fsamuel>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing webkit.review.bot: commit-queue-

Description Fady Samuel 2011-10-02 14:26:53 PDT
[Chromium] Moved files towards GTK removal
Comment 1 Fady Samuel 2011-10-02 14:27:41 PDT
Created attachment 109428 [details]
Patch
Comment 2 Tony Chang 2011-10-04 10:47:04 PDT
Comment on attachment 109428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109428&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:2312
>                                                   activeColor,
>                                                   trackColor);

Nit: Fix indent.
Comment 3 Tony Chang 2011-10-04 10:53:17 PDT
Created attachment 109647 [details]
Patch for landing
Comment 4 WebKit Review Bot 2011-10-04 13:06:35 PDT
Comment on attachment 109647 [details]
Patch for landing

Rejecting attachment 109647 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

Full output: http://queues.webkit.org/results/9954145
Comment 5 Tony Chang 2011-10-04 13:33:27 PDT
Created attachment 109673 [details]
Patch for landing
Comment 6 WebKit Review Bot 2011-10-04 15:42:43 PDT
Comment on attachment 109673 [details]
Patch for landing

Rejecting attachment 109673 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

Full output: http://queues.webkit.org/results/9930984
Comment 7 Tony Chang 2011-10-04 16:00:06 PDT
Committed r96660: <http://trac.webkit.org/changeset/96660>