Bug 69204

Summary: WTR is not successfully changing the NSUserDefaults
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Sam Weinig
Reported 2011-09-30 18:45:20 PDT
WTR should use swizzling to set user defaults, since it doesn't want to set them for all WebProcesses
Attachments
Patch (5.94 KB, patch)
2011-09-30 18:47 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2011-10-01 13:45 PDT, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-09-30 18:47:14 PDT
Created attachment 109391 [details] Patch
mitz
Comment 2 2011-09-30 19:24:05 PDT
I don’t understand what problem this is solving. Can you explain?
Sam Weinig
Comment 3 2011-09-30 20:33:07 PDT
It seems that just registering the defaults is not enough, as the tests are still running with overlay scrollbars. Setting the default explicitly would change it for all WebProcesses, so this seemed like the best way to work around the issue.
mitz
Comment 4 2011-09-30 20:53:07 PDT
Registering the default only makes a difference if it is not explicitly set in any other domain. I believe the proper way to do this is to set the defaults in an appropriately-identified persistent domain (using -setPersistentDomain:forName:) and then add that domain to the search order (using -addSuiteNamed). It would be nicer to do this without persistence, but I am not sure if that’s possible, and WebKit1 DumpRenderTree doesn’t do so either.
mitz
Comment 5 2011-09-30 21:01:52 PDT
I see now. Rather than creating a new volatile domain, you set the NSArgumentDomain, which is one of the volatile domains in the default search list (in fact, right at the top).
mitz
Comment 6 2011-09-30 21:02:45 PDT
Comment on attachment 109391 [details] Patch Please use -setVolatileDomain:forName:NSArgumentDomain instead.
Sam Weinig
Comment 7 2011-10-01 13:21:46 PDT
(In reply to comment #6) > (From update of attachment 109391 [details]) > Please use -setVolatileDomain:forName:NSArgumentDomain instead. Will do. Thanks for looking into an alternate way to do this.
Sam Weinig
Comment 8 2011-10-01 13:45:11 PDT
Created attachment 109407 [details] Patch
mitz
Comment 9 2011-10-01 13:47:01 PDT
Comment on attachment 109407 [details] Patch This trumps over any arguments actually passed on the command line, but I suppose that’s ok because the UI process composes the command line.
Sam Weinig
Comment 10 2011-10-01 13:47:54 PDT
Committed r96460: <http://trac.webkit.org/changeset/96460>
Note You need to log in before you can comment on or make changes to this bug.