Bug 69159

Summary: Add exact match attribute selectors to the fast path
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, mathias, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
now with more style, less printfs sam: review+

Antti Koivisto
Reported 2011-09-30 11:24:03 PDT
Attribute selectors are increasingly common and we have them in our default style sheet too. [foo] and [foo="bar"] type selectors can be resolved quicky and easily in the fast path.
Attachments
patch (17.84 KB, patch)
2011-09-30 11:44 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
now with more style, less printfs (17.46 KB, patch)
2011-09-30 12:02 PDT, Antti Koivisto 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2011-09-30 11:44:50 PDT
Created attachment 109318 [details] patch This is ~20% progression in styleForElement() performance loading the full HTML5 spec (~0.8s).
WebKit Review Bot
Comment 2 2011-09-30 11:47:14 PDT
Attachment 109318 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/SelectorChecker.h:87: The parameter name "attribute" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2011-09-30 12:02:40 PDT
Created attachment 109320 [details] now with more style, less printfs
Antti Koivisto
Comment 4 2011-10-03 10:39:34 PDT
http://trac.webkit.org/changeset/96517
Note You need to log in before you can comment on or make changes to this bug.