Summary: | [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zeno Albisser <zeno> | ||||||||
Component: | New Bugs | Assignee: | Zeno Albisser <zeno> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cshu, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Zeno Albisser
2011-09-30 06:53:01 PDT
Created attachment 109293 [details]
Patch
Comment on attachment 109293 [details]
Patch
it seems i'm not yet really mastering webkit-patch script. - sorry. ;-)
Comment on attachment 109293 [details]
Patch
How come there's no ChangeLog? :) Can you put some comments there why we should choose mouseevents over graphicsscenemouseevents?
Sorry, I didn't realize you cancelled the review. :) Created attachment 109294 [details]
patch for review.
Comment on attachment 109294 [details] patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=109294&action=review thanks for the change. > Tools/ChangeLog:6 > + This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105 i would suggest add more comments for the change. > Tools/WebKitTestRunner/EventSenderProxy.h:54 > + QMouseEvent* createMouseEvent(QEvent::Type, const QPoint& pos, const QPoint& screenPos, Qt::MouseButton, Qt::MouseButtons, Qt::KeyboardModifiers); We don't need a wrapper function any more. > Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:261 > + event = new QMouseEvent(type, pos, button, buttons, modifiers); Simply remove the whole thing and change the calling site. Created attachment 109297 [details]
patch for review - updated according to feedback.
Comment on attachment 109297 [details] patch for review - updated according to feedback. Clearing flags on attachment: 109297 Committed r96402: <http://trac.webkit.org/changeset/96402> All reviewed patches have been landed. Closing bug. |