Summary: | [UNIX] Add a method to get information for an already loaded plugin module | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca | ||||
Priority: | P2 | Keywords: | Gtk, Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 69123 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2011-09-30 01:30:12 PDT
Created attachment 109265 [details]
Patch
Comment on attachment 109265 [details]
Patch
Instead of adding getPluginInfo along with pluginInfo, I think it would be safer to ensure that getPluginInfo is safe to call at any time. I say this because it seems to work on Windows and Mac. If the other ports are making that assumption we should try to match it.
Other ports don't need to call NetscapePluginModule::getOrCreate() in getPluginInfo(), they use the plugin path directly. We need load the module to get the information. Comment on attachment 109265 [details]
Patch
Hrm. I took another look and I think your method is cleaner than adapting getPluginInfo to allow recursive calls. I think the danger of that happening is pretty low.
Committed r96400: <http://trac.webkit.org/changeset/96400> |