Bug 69134

Summary:

[Qt][WK2] Fix failing "narrow" tests after migrating to refactored Qt5

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Tor Arne Vestbø <vestbo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy, yael

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

69104

Attachments:

Description	Flags
Patch	vestbo: review-

Description Csaba Osztrogonác 2011-09-30 00:07:23 PDT

There are zillion similar failing tests. It seems the page is so narrow.

For example:
http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r96349%20%2812586%29/css2.1/20110323/absolute-non-replaced-height-001-pretty-diff.html

-layer at (0,0) size 800x600
-RenderView at (0,0) size 800x600
-layer at (0,0) size 800x22
+RenderView at (0,0) size 0x0
+layer at (0,0) size 0x304
+layer at (0,0) size 0x304

It seems that the width of the size is 0 pixel. :o

Comment 1 Tor Arne Vestbø 2011-09-30 08:59:02 PDT

Got a fix.

Comment 2 Tor Arne Vestbø 2011-09-30 12:44:57 PDT

Created attachment 109327 [details]
Patch

Comment 3 Tor Arne Vestbø 2011-09-30 13:05:28 PDT

Comment on attachment 109327 [details]
Patch

Landed in r96416

Comment 4 Csaba Osztrogonác 2011-10-03 03:15:33 PDT

This bug was fixed ... but css tests still fail because of metric differences. A volunteer have to check them manually one by one. :-/