Bug 69110

Summary: CSS grammar doesn't support functions with no parameters
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, macpherson, simon.fraser, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68469    
Attachments:
Description Flags
Patch
none
Patch dino: review+

Dean Jackson
Reported 2011-09-29 16:16:15 PDT
Something of the form 'function()' doesn't parse with the current CSS rules. It needs one or more parameters. A zero parameter function is allowed in CSS and used in CSS_FILTERS.
Attachments
Patch (18.74 KB, patch)
2011-10-28 09:35 PDT, Chris Marrin 		no flags
DetailsFormatted DiffDiff
Patch (31.96 KB, patch)
2011-10-28 13:24 PDT, Chris Marrin 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-09-29 16:17:00 PDT
<rdar://problem/10211555>
Chris Marrin
Comment 2 2011-10-28 09:35:39 PDT
Created attachment 112876 [details] Patch
Dean Jackson
Comment 3 2011-10-28 09:41:09 PDT
Comment on attachment 112876 [details] Patch Looks good. I have two small questions: - did you run all the existing LayoutTests? I'm worried this might break existing content (although I can't think of why) - Why no test for the computedStyle of things like grayscale() ?
Chris Marrin
Comment 4 2011-10-28 13:24:14 PDT
Created attachment 112899 [details] Patch
Chris Marrin
Comment 5 2011-10-28 15:55:52 PDT
Committed r98773: <http://trac.webkit.org/changeset/98773>
Note You need to log in before you can comment on or make changes to this bug.