Bug 69110

Summary:

CSS grammar doesn't support functions with no parameters

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

CSS

Assignee:

Chris Marrin <cmarrin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, macpherson, simon.fraser, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

68469

Attachments:

Description	Flags
Patch	none
Patch	dino: review+

Description Dean Jackson 2011-09-29 16:16:15 PDT

Something of the form 'function()' doesn't parse with the current CSS rules. It needs one or more parameters.

A zero parameter function is allowed in CSS and used in CSS_FILTERS.

Comment 1 Radar WebKit Bug Importer 2011-09-29 16:17:00 PDT

<rdar://problem/10211555>

Comment 2 Chris Marrin 2011-10-28 09:35:39 PDT

Created attachment 112876 [details]
Patch

Comment 3 Dean Jackson 2011-10-28 09:41:09 PDT

Comment on attachment 112876 [details]
Patch

Looks good. I have two small questions:

- did you run all the existing LayoutTests? I'm worried this might break existing content (although I can't think of why)
- Why no test for the computedStyle of things like grayscale() ?

Comment 4 Chris Marrin 2011-10-28 13:24:14 PDT

Created attachment 112899 [details]
Patch

Comment 5 Chris Marrin 2011-10-28 15:55:52 PDT

Committed r98773: <http://trac.webkit.org/changeset/98773>