Bug 69061

Summary: [EFL] Only set when the custom encoding is different from existing value
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2011-09-28 23:14:55 PDT
ewk_view_setting_encoding_custom_set() has set a new custom encoding unconditionally despite new custom encoding is same with existing value. This patch sets only new custom encoding when new custom encoding value is different from existing value.
Attachments
Patch (1.84 KB, patch)
2011-09-28 23:37 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2011-09-29 16:48 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.66 KB, patch)
2011-10-03 16:52 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-09-28 23:37:23 PDT
Created attachment 109124 [details] Patch
Leandro Pereira
Comment 2 2011-09-29 06:18:52 PDT
Comment on attachment 109124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109124&action=review Although this check could be made inside the embedder, it is harmless enough to be inside EWK. The change looks fine, just a minor nit in the ChangeLog entry. > Source/WebKit/efl/ChangeLog:10 > + ewk_view_setting_encoding_custom_set() has set a new custom encoding unconditionally > + despite new custom encoding is same with existing value. This patch sets only new > + custom encoding when new custom encoding value is different from existing value. ewk_view_setting_encoding_custom_set() sets a new custom ... value, reloading the page even when not needed. This patch sets the custom encoding only when the new value differs from the current value.
Gyuyoung Kim
Comment 3 2011-09-29 16:48:16 PDT
Created attachment 109221 [details] Patch
Gyuyoung Kim
Comment 4 2011-09-29 16:49:52 PDT
Leandro, thank you for your comment. I modify ChangeLog again.
Leandro Pereira
Comment 5 2011-09-30 06:50:01 PDT
Comment on attachment 109221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109221&action=review > Source/WebKit/efl/ChangeLog:10 > + ewk_view_setting_encoding_custom_set() has set a new custom encoding value, reloading > + the page even when not needed. This patch sets the custom encoding only when new value > + differ. Sorry to nitpick, but I think something along the lines of "Only set the custom encoding value if it is different from the current value, to avoid reloading the page." would be more clear.
Gyuyoung Kim
Comment 6 2011-10-03 16:52:49 PDT
Created attachment 109551 [details] Patch
Gyuyoung Kim
Comment 7 2011-10-03 16:53:09 PDT
I modify it again.
Leandro Pereira
Comment 8 2011-10-04 07:26:01 PDT
Comment on attachment 109551 [details] Patch Informal r+.
Hajime Morrita
Comment 9 2011-10-04 20:49:44 PDT
Comment on attachment 109551 [details] Patch Rubberstamped.
WebKit Review Bot
Comment 10 2011-10-04 21:55:15 PDT
Comment on attachment 109551 [details] Patch Clearing flags on attachment: 109551 Committed r96676: <http://trac.webkit.org/changeset/96676>
WebKit Review Bot
Comment 11 2011-10-04 21:55:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.