Bug 69055 – Check behavior of border attribute with a large number

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kent Tamura]

Bug 68981 exposed that we had never checked overflow of the attribute value.

[Kent Tamura]

Created attachment 109448 [details]
Patch

[Daniel Bates]

Comment on attachment 109448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109448&action=review

> LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border-expected.html:3
> +<p>Img elements with invalid border attribute should have the same appearnace with an img element without border attribute.</p>

appearnace => appearance

"with an" => "as an"

> LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border.html:3
> +<p>Img elements with invalid border attribute should have the same appearnace with an img element without border attribute.</p>

Ditto.

> LayoutTests/fast/dom/HTMLImageElement/image-with-invalid-border.html:5
> +<img src="resources/blue_rect.jpg" border=invalid>
> +<img src="resources/blue_rect.jpg" border=9999999999>

Nit: This is OK as-is. For your consideration, I suggest putting quotes around the attribute value for border so to be consistent with the quoting of the attribute value src. Throughout this patch there is an inconsistent quoting style for attribute values. I suggest choosing a style for consistency.

> LayoutTests/fast/dom/HTMLInputElement/input-with-invalid-border-expected.html:3
> +<p>Image input elements with invalid border attribute should have the same appearnace with an image input element without border attribute.</p>

Ditto.

> LayoutTests/fast/dom/HTMLInputElement/input-with-invalid-border.html:3
> +<p>Image input elements with invalid border attribute should have the same appearnace with an image input element without border attribute.</p>

Ditto.

> LayoutTests/fast/dom/HTMLObjectElement/object-with-invalid-border-expected.html:3
> +<p>Object elements with invalid border attribute should have the same appearnace with an object element without border attribute.</p>

Ditto.

> LayoutTests/fast/dom/HTMLObjectElement/object-with-invalid-border.html:3
> +<p>Object elements with invalid border attribute should have the same appearnace with an object element without border attribute.</p>

Ditto.

[Kent Tamura]

Daniel, thank you for reviewing.  I'll follow your comments and land the patch.

[Kent Tamura]

Committed r98083: <http://trac.webkit.org/changeset/98083>