Bug 69039

Summary: Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch abarth: review+, webkit.review.bot: commit-queue-

David Levin
Reported 2011-09-28 16:17:10 PDT
Need to check sys.platform and return if Windows.
Attachments
Patch (1.83 KB, patch)
2011-09-30 13:40 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
Patch (1.84 KB, patch)
2011-09-30 13:42 PDT, David Levin 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-09-30 13:40:20 PDT
Created attachment 109339 [details] Patch
David Levin
Comment 2 2011-09-30 13:42:51 PDT
Created attachment 109340 [details] Patch
WebKit Review Bot
Comment 3 2011-09-30 14:14:14 PDT
Comment on attachment 109340 [details] Patch Rejecting attachment 109340 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: 3305e141b1894930d4e6e809ed5f283c61f93e96 r96423 = 10e9ed80779e02bdb3af2a2cf49a19d95093cc9a Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9888922
David Levin
Comment 4 2011-09-30 14:38:08 PDT
Bummer I deleted the Reviewed by line :( Committed (by hand) as http://trac.webkit.org/changeset/96428.
Note You need to log in before you can comment on or make changes to this bug.