Bug 69024

Summary:

Add getCallData to MethodTable in ClassInfo

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

67690

Attachments:

Description	Flags
Patch	none
Patch	none

Description Mark Hahnenberg 2011-09-28 13:35:41 PDT

On the path to de-virtualizing JSCell::getCallData, we need to put it into the MethodTable in ClassInfo.

Comment 1 Mark Hahnenberg 2011-09-28 14:16:06 PDT

Created attachment 109077 [details]
Patch

Comment 2 Geoffrey Garen 2011-09-29 12:04:08 PDT

Comment on attachment 109077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=109077&action=review

r=me, with whitespace fix:

> Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:189
> +   ?getCallData@JSCell@JSC@@SA?AW4CallType@2@PAV12@AATCallData@2@@Z

I think this is a tab instead of a space, or just a missing space.

Comment 3 Mark Hahnenberg 2011-09-29 14:56:31 PDT

Created attachment 109208 [details]
Patch

Comment 4 WebKit Review Bot 2011-09-30 10:58:24 PDT

Comment on attachment 109208 [details]
Patch

Clearing flags on attachment: 109208

Committed r96406: <http://trac.webkit.org/changeset/96406>

Comment 5 WebKit Review Bot 2011-09-30 10:58:28 PDT

All reviewed patches have been landed.  Closing bug.