Summary: | Web Inspector: network log view refresh optimizations | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Kosyakov <caseq> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Andrey Kosyakov
2011-09-28 10:58:07 PDT
Created attachment 109038 [details]
patch
Comment on attachment 109038 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=109038&action=review > Source/WebCore/inspector/front-end/NetworkPanel.js:678 > + node.element.addStyleClass("offscreen"); You should move this to where the element is accessible after creation: WebInspector.NetworkDataGridNode.prototype.createCells in your case. > Source/WebCore/inspector/front-end/NetworkPanel.js:702 > + // FIXME: evaluate performance impact of moving this before a call to sortItems() Would be great to address it in this change. Note that while populating the log from scratch, wasScrolledToLastRow is always true. It might be that it is a noop though. Manually committ(In reply to comment #2) > (From update of attachment 109038 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=109038&action=review > > > Source/WebCore/inspector/front-end/NetworkPanel.js:678 > > + node.element.addStyleClass("offscreen"); > > You should move this to where the element is accessible after creation: WebInspector.NetworkDataGridNode.prototype.createCells in your case. Fixed! > > > Source/WebCore/inspector/front-end/NetworkPanel.js:702 > > + // FIXME: evaluate performance impact of moving this before a call to sortItems() > > Would be great to address it in this change. Note that while populating the log from scratch, wasScrolledToLastRow is always true. It might be that it is a noop though. it trquires a bit more of investigation (probably better benchmark) It's not a noop now, if I just move it to an earlier moment, we loose some 50ms. I'm going to come back to this after extending the benchmark suite with profiling-like methods. Manually committed r96318: http://trac.webkit.org/changeset/96318 |