Bug 69004 – REGRESSION(r96060) It made plugins/js-from-destroy.html crash in debug mode

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

Leopard: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r96219%20(33811)/plugins/js-from-destroy-crash-log.txt
Qt: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Debug/r96218%20(18602)/plugins/js-from-destroy-crash-log.txt
GTK: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r96215%20(17521)/plugins/js-from-destroy-crash-log.txt

[Nate Chapin]

The GTK stack is empty, and the Leopard stack doesn't yet make sense to me.

The Qt stack looks to me like ResourceLoader::m_documentLoader is possible due to an unintentional re-ordering in r96060.  I'll get a patch ready for that.

[Nate Chapin]

(In reply to comment #1)
> The GTK stack is empty, and the Leopard stack doesn't yet make sense to me.
> 
> The Qt stack looks to me like ResourceLoader::m_documentLoader is possible due to an unintentional re-ordering in r96060.  I'll get a patch ready for that.

Wow, I fail at proofreading.  That should have been:

The Qt stack looks to me like ResourceLoader::m_documentLoader is null, which is possible due to an unintentional re-ordering in r96060.

[Nate Chapin]

Created attachment 109039 [details]
Move DocumentLoader null check back to SubresourceLoader::create()

[WebKit Review Bot]

Comment on attachment 109039 [details]
Move DocumentLoader null check back to SubresourceLoader::create()

Rejecting attachment 109039 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9888257

[Csaba Osztrogonác]

Comment on attachment 109039 [details]
Move DocumentLoader null check back to SubresourceLoader::create()

Clearing flags on attachment: 109039

Committed r96249: <http://trac.webkit.org/changeset/96249>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.